Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readline): flickering on line refresh #288

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

TorchedSammy
Copy link
Member

closes #285

  • I have documented changes and additions in the CHANGELOG.md.

@TorchedSammy TorchedSammy added this to the v2.3 (Alyssum) milestone Apr 11, 2024
@sleeptightAnsiC
Copy link

sleeptightAnsiC commented Apr 11, 2024

#285 is still occuring on my side after the patch, see for reference: #285 (comment)

@TorchedSammy TorchedSammy changed the title fix(readline): hide cursor when updating helpers fix(readline): flickering on line refresh Apr 11, 2024
@sleeptightAnsiC
Copy link

I can see a huge difference on 9cc032f
#285 might not be relevant anymore but current behavior still isn't perfect - discord message for reference

2024-04-12.01-42-07.mp4

@sleeptightAnsiC
Copy link

512f96e - text blinking is fully gone in getty. I can still notice cursor appearing on the beginning/end of current/next line.
No video this time as it would look pretty much the same as the one from my previous comment.
https://discord.com/channels/732357621503229962/732357622216392767/1229805577660661800

@TorchedSammy TorchedSammy merged commit d1dbb84 into master Apr 16, 2024
17 of 18 checks passed
@TorchedSammy TorchedSammy removed this from the v2.3 (Alyssum) milestone Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: cursor and text blinks while being edited / refreshed
2 participants